Skip to content

Use the local kubelet's cluster domain, rather than a random one#1071

Merged
nightkr merged 4 commits intomainfrom
feature/cluster-detection-local-kubelet
Jul 3, 2025
Merged

Use the local kubelet's cluster domain, rather than a random one#1071
nightkr merged 4 commits intomainfrom
feature/cluster-detection-local-kubelet

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Jul 3, 2025

Description

Part of stackabletech/issues#662, followup to #1068.

This is a breaking change (towards operators); they must now (in addition to the requirements from #1068) also provide the following environment variable:

env:
  - name: KUBERNETES_NODE_NAME
    valueFrom:
      fieldRef:
        fieldPath: spec.nodeName

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@nightkr nightkr mentioned this pull request Jul 3, 2025
Merged
13 tasks
@nightkr nightkr requested review from a team, razvan and sbernauer July 3, 2025 10:34
@nightkr nightkr moved this to Development: Waiting for Review in Stackable Engineering Jul 3, 2025
@nightkr nightkr mentioned this pull request Jul 3, 2025
Closed
14 tasks
@nightkr
Copy link
Contributor Author

nightkr commented Jul 3, 2025

Adapted list-op as an example: stackabletech/listener-operator#317

@sbernauer
Copy link
Member

sbernauer commented Jul 3, 2025

Will review later when I get time, just FYI that #1066 also touches CLI arguments.
Maybe you can benefit from that or the other way around

@nightkr
Copy link
Contributor Author

nightkr commented Jul 3, 2025

Doesn't look like that touches the node name, but it probably makes sense to run the templating rollouts together.

@sbernauer
Copy link
Member

sbernauer commented Jul 3, 2025

Was thinking the same. Regarding templating I already have stackabletech/operator-templating#534

sbernauer
sbernauer previously approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however the tests currently fail

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 3, 2025
@sbernauer
Copy link
Member

sbernauer commented Jul 3, 2025

Also giving @razvan the chance to review

@nightkr
Copy link
Contributor Author

nightkr commented Jul 3, 2025

Oh. Right. I had updated the code tets, but not the doctests.

razvan
razvan approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@nightkr nightkr enabled auto-merge July 3, 2025 11:58
@nightkr nightkr added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 7328943 Jul 3, 2025
8 checks passed
@nightkr nightkr deleted the feature/cluster-detection-local-kubelet branch July 3, 2025 12:06
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 4, 2025
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jul 4, 2025
@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jul 4, 2025
@sbernauer sbernauer mentioned this pull request Jul 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razvan razvan razvan approved these changes

@sbernauer sbernauer sbernauer left review comments

Assignees

No one assigned

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nightkr @sbernauer @razvan